Fixed MathJax code being displayed twice by dsMarkdown
pipe
#2397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
dsMarkdown
pipe #2392Description
Fixed MathJax code being displayed twice, this is because a HTML tag
mjx-assistive-mml
is created for screen readers to be able to read the MathJax code. Because thedsMarkdown
pipe sanitises the HTML it transformed this hidden HTML tag to text instead leading to the MathJax code being displayed twice.Instructions for Reviewers
List of changes in this PR:
mjx-assistive-mml
HTML tag (and it's child HTML tags) to thesanitizeHtml
'sallowedTags
to ensure it won't be turned into textGuidance for how to test/review this PR:
dc.description.abstract
:Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.