Opening the simple item page of a withdrawn item when logged in as administrator stalls the frontend instance

[MW3000]

Describe the bug

In DSpace 8.x, opening the simple item page of a withdrawn item when logged in as administrator stalls the frontend instance for about 10 to 15 minutes, making it unresponsive, then continues to display the simple item page.

To Reproduce

Steps to reproduce the behavior:

1. Login as an administrator
2. Withdraw an item
3. Go the withdrawn item's simple item page, eg. by clicking the item in the breadcrumbs, searching for a withdrawn item in administrative search or because you copied the url beforehand.
4. The whole frontend instance stalls for about 10 to 15 minutes. After that time, the simple item page is displayed.

You can easily reproduce this on the DSpace Demo Website

Expected behavior

The simple item page should come up immediately

[Leano1998]

Hi,
I looked a bit deeper into this and figured, it might be a problem with the cache of the authorization information:

  showReinstateButton$(): Observable<boolean>  {
    const correction$ = this.correctionTypeDataService.findByItem(this.item.uuid, true).pipe(
      getFirstCompletedRemoteData(),
      map((correctionTypeRD: RemoteData<PaginatedList<CorrectionType>>) => correctionTypeRD.hasSucceeded ? correctionTypeRD.payload.page : []),
    );
    const isAdmin$ = this.authService.isAuthorized(FeatureID.AdministratorOf);
    return combineLatest([isAdmin$, correction$]).pipe(
      map(([isAdmin, correction]) => {
        return !isAdmin && correction.some((correctionType) => correctionType.topic === REQUEST_REINSTATE);
      },
      ));
  }

If I force the authService not to use the cached version, it works for me, otherwise it seems to return undefined.

    const isAdmin$ = this.authService.isAuthorized(FeatureID.AdministratorOf, undefined, undefined, false);

[alexandrevryghem]

@Leano1998: The problem is most likely that the template always recreates a new Observable every time the template is rerenderd. I already have a branch with similar fixes on other places that I was going to contribute, I can add that fix to that branch too 🤷

dspace-angular/src/app/item-page/alerts/item-alerts.component.html

Line 11 in 8cc45e8

<a *ngIf="showReinstateButton$() | async" class="btn btn-primary btn-sm" (click)="openReinstateModal()">{{ 'item.alerts.reinstate-request' | translate}}</a>

[Leano1998]

@alexandrevryghem : Yes, I noticed this behavior in the browser console. Thank you for the adding the fix!

[alanorth]

Interesting... I haven't noticed this on DSpace 7.6.x. We have many withdrawn items so I would have definitely run into this.

[alexandrevryghem]

Indeed, only dspace-8_x and main are affected since this originates from this PR, which hasn't been backported to dspace-7_x.