-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed observable function calls from template (part 1) #3585
Open
alexandrevryghem
wants to merge
11
commits into
DSpace:main
Choose a base branch
from
alexandrevryghem:w2p-117573_remove-observable-function-calls_contribute-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Removed observable function calls from template (part 1) #3585
alexandrevryghem
wants to merge
11
commits into
DSpace:main
from
alexandrevryghem:w2p-117573_remove-observable-function-calls_contribute-main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… between different groups Also fixed edit ePerson not showing the group names
…te-7.6' into w2p-117573_remove-observable-function-calls_contribute-main # Conflicts: # src/app/access-control/epeople-registry/eperson-form/eperson-form.component.html # src/app/access-control/group-registry/group-form/group-form.component.ts
alexandrevryghem
added
bug
high priority
performance / caching
Related to performance, caching or embedded objects
component: Item
(Archived) Item display or editing
claimed: Atmire
Atmire team is working on this issue & will contribute back
port to dspace-7_x
This PR needs to be ported to `dspace-7_x` branch for next bug-fix release
port to dspace-8_x
This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
labels
Oct 29, 2024
alexandrevryghem
force-pushed
the
w2p-117573_remove-observable-function-calls_contribute-main
branch
from
October 29, 2024 17:48
9ef1f65
to
0cb5b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
claimed: Atmire
Atmire team is working on this issue & will contribute back
component: Item
(Archived) Item display or editing
high priority
performance / caching
Related to performance, caching or embedded objects
port to dspace-7_x
This PR needs to be ported to `dspace-7_x` branch for next bug-fix release
port to dspace-8_x
This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Currently, there are multiple instances where observable function calls are subscribed to directly in the template. This is considered a bad practice, as it cause a new Observable to be recreated each time Angular’s change detection is triggered. Some instances of this issue remain, but I will work on creating PRs to address them over the coming months.
Instructions for Reviewers
Guidance for how to test & review this PR:
Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.