Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails do not always load on item page when MediaViewer enabled #2660

Closed
recived opened this issue Nov 23, 2023 · 6 comments
Closed

Thumbnails do not always load on item page when MediaViewer enabled #2660

recived opened this issue Nov 23, 2023 · 6 comments
Assignees
Labels
bug component: Item (Archived) Item display or editing help wanted Needs a volunteer to claim to move forward high priority
Milestone

Comments

@recived
Copy link

recived commented Nov 23, 2023

Describe the bug
Dspace >=7.6.0. Tested in local server, demo.dspace.org, testrephip.unr.edu.ar. If the item page has not been visited for a long time , then the thumbnail does not load (page needs to be refreshed or open in new window). Full item page is ok. I suspect the problem is in the media viewer.

image

@recived recived added bug needs triage New issue needs triage and/or scheduling labels Nov 23, 2023
@recived
Copy link
Author

recived commented Nov 23, 2023

/src/app/item-page/media-viewer/media-viewer.component.html, after removing <div class="media-viewer" *ngIf="!isLoading"> partially solves the problem. Thumbnails load fine, animation is playing.

image

or temporary solution dspace-angular/src/app/item-page/media-viewer/media-viewer.component.ts

    this.thumbnailsRD$ = this.loadRemoteData('THUMBNAIL');
    if (this.thumbnailsRD$) { 
      this.isLoading = false;
    }

@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward component: Item (Archived) Item display or editing high priority and removed needs triage New issue needs triage and/or scheduling labels Nov 27, 2023
@tdonohue
Copy link
Member

Pulled this over to the 7.6.x maintenance board. Needs a volunteer to investigate & create a PR to fix.

@mspalti
Copy link
Member

mspalti commented Nov 30, 2023

We are seeing this issue fairly consistently in 7.6.1. Adding manual change detection seems to fix the problem #2673

@mspalti mspalti self-assigned this Nov 30, 2023
@recived
Copy link
Author

recived commented Nov 30, 2023

We are seeing this issue fairly consistently in 7.6.1. Adding manual change detection seems to fix the problem #2673

Thank you. problem solved.

@tdonohue tdonohue changed the title Thumbnails does not load on item page Thumbnails do not always load on item page when MediaViewer enabled Nov 30, 2023
@tdonohue
Copy link
Member

I was able to reproduce this locally in the following scenario (Not sure if this is a common scenario, but I wanted to point it out as well):

  1. Enable MediaViewer
  2. Visit an Item page for an Item that has a Thumbnail from a PDF Bitstream. Thumbnail doesn't load.
    • However, I've found when the Item has a thumbnail created from an image Bitstream, it will oftentimes load properly. (At least I've found it harder to reproduce in this scenario.)

In any case, I've found that @mspalti 's small fix in #2673 also works for me.

@tdonohue tdonohue added this to the 7.6.2 milestone Nov 30, 2023
@tdonohue
Copy link
Member

tdonohue commented Dec 1, 2023

Closing, fixed by #2673

@tdonohue tdonohue closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: Item (Archived) Item display or editing help wanted Needs a volunteer to claim to move forward high priority
Projects
Development

No branches or pull requests

3 participants