Fix for loading thumbnail images for Items when MediaViewer enabled

[mspalti]

References

• This fix seems related to Thumbnails do not always load on item page when MediaViewer enabled #2660

Description

Thumbnail images are failing to load for us (consistently) as shown in #2660. This is new for us in 7.6.1 7.6.

I think that Angular isn't detecting the update of the isLoading property in the subscription. Perhaps because of the new fallback to the ds-thumbnail component? In any case, forcing change detection with changeDetectorRef.detectChanges() after isLoading gets updated seems to fix this problem.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

• Added manual change detection

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @mspalti ! As I noted in the original ticket, this fixes the issue that I was able to reproduce. See #2660 (comment)

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Fix for loading thumbnail images for Items when MediaViewer enabled #2677