Skip to content

Commit

Permalink
Remove unnecessary @ts-expect-error, as the bug they are expecting is…
Browse files Browse the repository at this point in the history
… fixed in webpack 5.95.0.
  • Loading branch information
tdonohue committed Oct 22, 2024
1 parent 24b7d38 commit d634903
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion webpack/webpack.common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ const SCSS_LOADERS = [

export const commonExports = {
plugins: [
// @ts-expect-error: EnvironmentPlugin constructor types are currently to strict see issue https://github.com/webpack/webpack/issues/18719
new EnvironmentPlugin({
languageHashes: getFileHashes(path.join(__dirname, '..', 'src', 'assets', 'i18n'), /.*\.json5/g),
}),
Expand Down
1 change: 0 additions & 1 deletion webpack/webpack.prod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { commonExports } from './webpack.common';
module.exports = Object.assign({}, commonExports, {
plugins: [
...commonExports.plugins,
// @ts-expect-error: EnvironmentPlugin constructor types are currently to strict see issue https://github.com/webpack/webpack/issues/18719
new EnvironmentPlugin({
'process.env': {
NODE_ENV: 'production',
Expand Down

0 comments on commit d634903

Please sign in to comment.