Skip to content

Commit

Permalink
Merge branch 'fix-ngonchanges-not-working-for-themed-components_contr…
Browse files Browse the repository at this point in the history
…ibute-7.2' into fix-ngonchanges-not-working-for-themed-components_contribute-7.4

# Conflicts:
#	src/app/app.component.ts
  • Loading branch information
alexandrevryghem authored and tdonohue committed Aug 25, 2023
1 parent 7352d9e commit 8b57a2f
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions src/app/shared/theme-support/theme.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -240,14 +240,7 @@ export class ThemeService {
if (hasValue(parentThemeName)) {
// inherit the head tags of the parent theme
return this.createHeadTags(parentThemeName);
}
const defaultThemeConfig = getDefaultThemeConfig();
const defaultThemeName = defaultThemeConfig.name;
if (
hasNoValue(defaultThemeName) ||
themeName === defaultThemeName ||
themeName === BASE_THEME_NAME
) {
} else {
// last resort, use fallback favicon.ico
return [
this.createHeadTag({
Expand All @@ -260,9 +253,6 @@ export class ThemeService {
})
];
}

// inherit the head tags of the default theme
return this.createHeadTags(defaultThemeName);
}

return headTagConfigs.map(this.createHeadTag.bind(this));
Expand Down

0 comments on commit 8b57a2f

Please sign in to comment.