Fix ACE_Logging_Strategy::handle_timeout returning -1 without releasing ACE_Log_Msg lock
#2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likema
changed the title
ACE_Logging_Strategy::handle_timeout returning -1 without releasing ACE_Log_Msg lockACE_Logging_Strategy::handle_timeout returning -1 without releasing ACE_Log_Msg lock
…ng ACE_Log_Msg lock
likema
force-pushed
the
log-strategy-lock
branch
from
5324f14
to
9dd8a78
Compare
|
Don’t force push, makes it harder to review, use nullptr instead of 0 |
OK. Shall I combine two commits into one after reviewed so that keep one issue per commit? |
|
No need to squash, please add/extend a unit test as reproducer |
jwillemsen
reviewed
Jul 24, 2024
ACE/ace/Logging_Strategy.cpp
Outdated
| @@ -442,7 +442,8 @@ ACE_Logging_Strategy::handle_timeout (const ACE_Time_Value &, | |||
| // Close the current ostream. | |||
| #if defined (ACE_LACKS_IOSTREAM_TOTALLY) | |||
| FILE *output_file = (FILE *) this->log_msg_->msg_ostream (); | |||
| ACE_OS::fclose (output_file); | |||
| if (output_file) | |||
| ACE_OS::fclose (output_file); | |||
There was a problem hiding this comment.
setting to nullptr only when it is non null?
There was a problem hiding this comment.
After this line, output_file is assigned before using.
There was a problem hiding this comment.
I meant the part this->log_msg_->msg_ostream (nullptr);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before changed, there were two snippets in
ACE_Logging_Strategy::handle_timeout:whiich would return without releasing
ACE_Log_Msglock