Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACE 6] Avoid potential out-of-bounds read in ACE_CDR::Fixed::from_string #2196

Merged
merged 2 commits into from
Feb 9, 2024
Merged

[ACE 6] Avoid potential out-of-bounds read in ACE_CDR::Fixed::from_string #2196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90258af
Avoid potential out-of-bounds read in ACE_CDR::Fixed::from_string
mitza-oci Feb 9, 2024
794ab90
Merge remote-tracking branch 'upstream/ace6tao2' into ace6-cdrfixed
mitza-oci Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ACE/ace/CDR_Base.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ ACE_CDR::Fixed ACE_CDR::Fixed::from_string (const char *str)
++f.digits_;
}

if (!f.scale_ && str[span - f.digits_ - 1] == '.')
if (!f.scale_ && span > f.digits_ && str[span - f.digits_ - 1] == '.')
f.scale_ = f.digits_;

if (idx >= 0)
Expand Down
Loading