-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2832 form subject browser #2420
Open
amdomanska
wants to merge
12
commits into
feature/2832_subject_tree_rendering_changes
Choose a base branch
from
feature/2832_form_subject_browser
base: feature/2832_subject_tree_rendering_changes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/2832 form subject browser #2420
amdomanska
wants to merge
12
commits into
feature/2832_subject_tree_rendering_changes
from
feature/2832_form_subject_browser
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amdomanska
changed the base branch from
develop
to
feature/2832_subject_tree_rendering_changes
September 23, 2024 12:35
…re/2832_form_subject_browser
Changes in edges: |
amdomanska
requested review from
richard-jones,
Steven-Eardley,
RK206 and
philipkcl
September 24, 2024 11:07
richard-jones
changed the base branch from
feature/2832_subject_tree_rendering_changes
to
develop
October 23, 2024 13:08
richard-jones
changed the base branch from
develop
to
feature/2832_subject_tree_rendering_changes
October 23, 2024 13:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of: #2349
Issue: https://github.com/DOAJ/doajPM/issues/2832
Extend the behaviour changes to form Subject Tree. Refactor to use Edges renderer and the core behaviour of the Tree Browser Component. Add the Form component in formulaic to define the form-specific behaviour.
briefly describe the PR here
This PR...
Developer Checklist
Developers should review and confirm each of these items before requesting review
constants
ormessages
filesdates
)url_for
not hard-coded[feature/2832_subject_tree_rendering_changes](https://github.com/DOAJ/doaj/tree/feature/2832_subject_tree_rendering_changes)
(23/09/24)Reviewer Checklist
Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Testing
Requirements doc: https://docs.google.com/spreadsheets/d/1T_zIXfmWd7i0MyMbrL8hpg6zczml39-gcejTwDVvWAo/edit?gid=0#gid=0
Functional tests with:
To be tested after merging to #2349
List any non-unit test scripts that need to be run by reviewers
Deployment
What deployment considerations are there? (delete any sections you don't need)
Configuration changes
What configuration changes are included in this PR, and do we need to set specific values for production
Scripts
What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).
Migrations
What migrations need to be run to deploy this
Monitoring
What additional monitoring is required of the application as a result of this feature
New Infrastructure
What new infrastructure does this PR require (e.g. new services that need to run on the back-end).
Continuous Integration
What CI changes are required for this