Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2832 form subject browser #2420

Open
wants to merge 12 commits into
base: feature/2832_subject_tree_rendering_changes
Choose a base branch
from

Conversation

amdomanska
Copy link
Contributor

@amdomanska amdomanska commented Sep 23, 2024

Continuation of: #2349
Issue: https://github.com/DOAJ/doajPM/issues/2832


Extend the behaviour changes to form Subject Tree. Refactor to use Edges renderer and the core behaviour of the Tree Browser Component. Add the Form component in formulaic to define the form-specific behaviour.

briefly describe the PR here

This PR...

  • has scripts to run
  • has migrations to run
  • adds new infrastructure
  • changes the CI pipeline
  • affects the public site
  • affects the editorial area
  • affects the publisher area
  • affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migration has been created and tested
  • There is a recent merge from [feature/2832_subject_tree_rendering_changes](https://github.com/DOAJ/doaj/tree/feature/2832_subject_tree_rendering_changes) (23/09/24)

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Testing

Requirements doc: https://docs.google.com/spreadsheets/d/1T_zIXfmWd7i0MyMbrL8hpg6zczml39-gcejTwDVvWAo/edit?gid=0#gid=0

Functional tests with:
To be tested after merging to #2349

List any non-unit test scripts that need to be run by reviewers

Deployment

What deployment considerations are there? (delete any sections you don't need)

Configuration changes

What configuration changes are included in this PR, and do we need to set specific values for production

Scripts

What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).

Migrations

What migrations need to be run to deploy this

Monitoring

What additional monitoring is required of the application as a result of this feature

New Infrastructure

What new infrastructure does this PR require (e.g. new services that need to run on the back-end).

Continuous Integration

What CI changes are required for this

@amdomanska amdomanska changed the base branch from develop to feature/2832_subject_tree_rendering_changes September 23, 2024 12:35
@amdomanska
Copy link
Contributor Author

Changes in edges:

CottageLabs/edges#49

@amdomanska amdomanska marked this pull request as ready for review September 24, 2024 11:08
@richard-jones richard-jones changed the base branch from feature/2832_subject_tree_rendering_changes to develop October 23, 2024 13:08
@richard-jones richard-jones changed the base branch from develop to feature/2832_subject_tree_rendering_changes October 23, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants