-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3925 oai delete #2418
base: develop
Are you sure you want to change the base?
Feature/3925 oai delete #2418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks good and working when tested.
One testcase always failing when run with complete tests for test_oaipmh. But it passed when executed alone. Not sure if it is with my environment.
doajtest/unit/test_oaipmh.py:321 (TestClient.test_09_article)
1 != 3
Expected :3
Actual :1
There is no migration script. I believe ArticleTombstone should be indexed when application restarted. I could not able to test the migration as I did anon_import.
Add deleted records to OAI-PMH
Adds withdrawn Journals and withdrawn and deleted Articles to the OAI-PMH feed with the "deleted" status. This means adding an Article Tombstone type, which records all article deletes and incorporating that data into the PMH feed.
This PR...
Developer Checklist
Developers should review and confirm each of these items before requesting review
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
(2024-09-16)Reviewer Checklist
Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Testing
There is no user script for this to be tested, but we should do the following:
Then review the feed and confirm that all affected records appear on the OAI feed.
Deployment
No additional deployment considerations.