feature/3838_handle_exception

doajtest/unit/test_view_publisher.py

@@ -0,0 +1,21 @@
+from doajtest import helpers
+from doajtest.helpers import DoajTestCase
+from portality import models, constants
+from portality.util import url_for
+
+
+class TestViewPublisher(DoajTestCase):
+
+    def test_delete_application__no_such_object(self):
+        pwd = 'password'
+        un = 'publisher_a'
+        acc = models.Account.make_account(un + "@example.com", un, "Publisher " + un, [constants.ROLE_PUBLISHER])
+        acc.set_password(pwd)
+        acc.save(blocking=True)
+
+        with self.app_test.test_client() as t_client:
+            resp = helpers.login(t_client, acc.email, pwd)
+            assert resp.status_code == 200
+
+            resp = t_client.get(url_for("publisher.delete_application", application_id='no_such_id'))
+            assert resp.status_code == 404

portality/view/publisher.py

@@ -4,7 +4,8 @@
 
 from portality.app_email import EmailException
 from portality import models, constants
-from portality.bll.exceptions import AuthoriseException, ArticleMergeConflict, DuplicateArticleException, ArticleNotAcceptable
+from portality.bll.exceptions import AuthoriseException, ArticleMergeConflict, DuplicateArticleException, \
+    ArticleNotAcceptable, NoSuchObjectException
 from portality.decorators import ssl_required, restrict_to_role, write_required
 from portality.dao import ESMappingMissingError
 from portality.forms.application_forms import ApplicationFormFactory
@@ -54,7 +55,10 @@ def delete_application(application_id):
 
     # otherwise delegate to the application service to sort this out
     appService = DOAJ.applicationService()
-    appService.delete_application(application_id, current_user._get_current_object())
+    try:
+        appService.delete_application(application_id, current_user._get_current_object())
+    except NoSuchObjectException:
+        abort(404)
 
     return redirect(url_for("publisher.deleted_thanks"))