Change requester get measurement flow #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
May 23, 2024
| @@ -109,14 +109,56 @@ libspdm_return_t spdm_send_receive_get_measurement(void *spdm_context, | |||
| index, m_use_slot_id & 0xF, requester_context, NULL, &number_of_block, | |||
| &measurement_record_length, measurement_record, | |||
| NULL, NULL, NULL, NULL, NULL); | |||
| if (LIBSPDM_STATUS_IS_ERROR(status)) { | |||
| if ((LIBSPDM_STATUS_IS_ERROR(status)) && (status != LIBSPDM_STATUS_VERIF_FAIL)) { | |||
There was a problem hiding this comment.
Thanks. I have changed the line to its original form.
Wenxing-hou
force-pushed
the
fix_get_measure_flow
branch
from
5f689ca
to
dd87484
Compare
Fix the issue: DMTF#346 Because the L1/L2 will be reset in case of MEASUREMENT error, it will impact 1-by-1 calculation. The solution is: get the existing measurement list before 1-by-1 get measurement. The change has passed the test. Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
fix_get_measure_flow
branch
from
dd87484
to
0c22a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #346
Because the L1/L2 will be reset in case of
MEASUREMENT error, it will impact 1-by-1 calculation.
The solution is: get the existing measurement list before 1-by-1 get measurement.
The change has passed the test.