Fix get_csr for SPDM 1.3 #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will fix the sync libspdm error. And this PR will pass the CI after sync the libspdm. |
jyao1
reviewed
Jan 11, 2024
| } else { | ||
| #if LIBSPDM_ENABLE_CAPABILITY_CSR_CAP_EX | ||
| request_attribute = 0; | ||
| key_pair_id = 1; |
There was a problem hiding this comment.
This is wrong. Need evaluate if MULTI_KEY_CONN
jyao1
reviewed
Jan 11, 2024
| printf("libspdm_get_csr - %x\n", | ||
| (uint32_t)status); | ||
| return status; | ||
| if (m_use_version == SPDM_MESSAGE_VERSION_12) { |
There was a problem hiding this comment.
This is wrong. The API can still be used in case of no MULTI_KEY_CONN.
Wenxing-hou
force-pushed
the
fix_get_csr
branch
from
c8b3521
to
e8e76cb
Compare
Wenxing-hou
force-pushed
the
fix_get_csr
branch
2 times, most recently
from
408db57
to
984e57d
Compare
Wenxing-hou
force-pushed
the
fix_get_csr
branch
from
984e57d
to
c1f34ca
Compare
Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
fix_get_csr
branch
from
c1f34ca
to
4a5205f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.