Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GetLoftWithCutOuts() in CCPACSWing crashes without warning (Issue #1022) #1023

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

merakulix
Copy link
Contributor

Description

See Issue #1022.

Changed CCPACSWing::GetLoftWithCutOuts() to return a warning and a clean shape if no control surfaces are defined.

How Has This Been Tested?

Added Unittest to tiglWing.cpp to assert that warning is thrown and shape is valid.

Screenshots, that help to understand the changes(if applicable):

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.04%. Comparing base (a334bd3) to head (f84420b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/wing/CCPACSWing.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   70.03%   70.04%   +0.01%     
==========================================
  Files         301      301              
  Lines       24312    24315       +3     
==========================================
+ Hits        17026    17031       +5     
+ Misses       7286     7284       -2     
Flag Coverage Δ
unittests 70.04% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/wing/CCPACSWing.cpp 78.07% <75.00%> (+0.54%) ⬆️

Copy link
Contributor

@joergbrech joergbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix with unit test! I found one small issue with the usage of GTests test fixtures.

tests/unittests/tiglWing.cpp Show resolved Hide resolved
@joergbrech joergbrech merged commit 52cdb0e into master Aug 29, 2024
17 checks passed
@joergbrech joergbrech deleted the loftWithCutouts branch August 29, 2024 20:56
@joergbrech
Copy link
Contributor

Thanks @merakulix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants