-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Fuselage Profile Type: Rectangle (Issue #909) #1005
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
+ Coverage 70.03% 70.19% +0.16%
==========================================
Files 301 301
Lines 24312 24429 +117
==========================================
+ Hits 17026 17148 +122
+ Misses 7286 7281 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Jan Kleinert <[email protected]>
I updated the code to generate the profiles using the CFunctionToBSpline function. On my local machine unit-and integration tests ran successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @merakulix! This looks really good! Just one minor cosmetic change and this is good to merge
Description
Implementing the rectangle profile type as an element of the CPACS standard profile type covers one part of issue #909 on parametric profile types.
This approach is based on point lists (std::vector<gp_Pnt>) for approximation of curves, since the lofting algorithms don't support rational B-Splines yet.
Changes in tiglcommonfunctions.* :
Added new global functions:
- BuildWireRectangle(... , ): Builds the wire which is needed to build profiles. Uses these newly implemented functions:
- ApproximateArcOfCircleToRationalBSpline(... , ): Approximation to a rational B-Spline via point list was needed, since the lofting algorithm doesn't support rational B-Splines yet
- Linspace(... , ): Useful function when building point lists
Changes in CCPACSFuselageProfile.* :
Added new member function
Changed member function:
How Has This Been Tested?
Added Unit Tests:
a circle profile with kinks and a rectangle profile with and without corner radius, as shown in the image below
circle profile, rectangle profile with and without corner radius given, and guide curves, as shown in the images below
Checklist: