Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): Fixes optical flow rgb output key #963

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

cornerfarmer
Copy link
Member

@cornerfarmer cornerfarmer commented Aug 21, 2023

RGB should now no longer overwrite optical flow output, even when output_format is set to exr.

Fixes: #684

@cla-bot cla-bot bot added the cla-signed label Aug 21, 2023
@cornerfarmer cornerfarmer force-pushed the iss_684_optical_flow_fix_rgb_key branch from 87d7bce to b8f1cd4 Compare August 21, 2023 22:00
@cornerfarmer
Copy link
Member Author

cornerfarmer commented Aug 21, 2023

BlenderProcHelper result for run 527:

Done with: [amass_human_poses_python 37s, auto_shading_python 9s, basic_python 15s, blenderkit_python 19s, bop_object_on_surface_sampling_python 89s, bop_object_physics_positioning_python 120s, bop_object_pose_sampling_python 43s, bop_scene_replication_python 172s, camera_depth_of_field_python 20s, camera_object_pose_python 16s, camera_random_trajectories_python 52s, camera_sampling_python 19s, coco_annotations_python 16s, diffuse_color_image_python 19s, dust_python 18s, entity_displacement_modifier_python 14s, entity_manipulation_python 10s, front_3d_object_sampling_python 84s, front_3d_python 96s, front_3d_with_improved_mat_python 98s, git_log 1s, haven_python 22s, ikea_python 17s, kinect_azure_noise_python 14s, lens_distortion_python 15s, lens_distortion_python 13s, light_sampling_python, material_manipulation_python 10s, material_randomizer_python 14s, matterport3d_python 71s, motion_blur_rolling_shutter_python 32s, motion_blur_rolling_shutter_python 26s, multi_render_python 253s, nocs_python 18s, object_pose_sampling_python 10s, on_surface_object_sampling_python 10s, optical_flow_python 26s, physics_convex_decomposition_python 127s, physics_positioning_python 22s, pix3d_python 16s, random_backgrounds_python 17s, random_room_constructor_python 85s, replica_python 354s, scenenet_python 53s, scenenet_with_cctextures_python 56s, semantic_segmentation_python 15s, shapenet_python, shapenet_with_scenenet_python 57s, shapenet_with_suncg_python 68s, spotlight_python 31s, stereo_matching_python 43s, stereo_matching_with_projector_python 141s, suncg_basic_python 33s, suncg_with_cam_sampling_python 59s, suncg_with_improved_mat_python 79s, suncg_with_object_replacer_python 63s, tests_python 14s, urdf_loading_and_manipulation_python 52s]
Done with 58 of 58 tests.
There were errors:
Unit tests output:

...........
----------------------------------------------------------------------
Ran 11 tests in 8.800s

OK

stereo_matching (main_python)

The output of stereo_matching:main_python:disparity has changed: Diff: 0.0897, Pixel diff: 0.0256



Compare image Newly generated image

The output of stereo_matching:main_python:stereo-depth has changed: Diff: 0.0059, Pixel diff: 0.0248



Compare image Newly generated image

The output of stereo_matching:main_python:disparity has changed: Diff: 0.2161, Pixel diff: 0.0513



Compare image Newly generated image

The output of stereo_matching:main_python:stereo-depth has changed: Diff: 0.0126, Pixel diff: 0.0511



Compare image Newly generated image

stereo_matching_with_projector (main_python)

The output of stereo_matching_with_projector:main_python:disparity has changed: Diff: 0.0127, Pixel diff: 0.0043



Compare image Newly generated image

Pylint output

Expand

Messages

Module blenderproc.debug_startup (blenderproc/debug_startup.py)

Line Col. Type Symbol ID Obj Message
4 0 warning unused-import W0611
Unused Path imported from pathlib

Module blenderproc.python.loader.BopLoader (blenderproc/python/loader/BopLoader.py)

Line Col. Type Symbol ID Obj Message
54 22 warning f-string-without-interpolation W1309 load_bop_objs
Using an f-string that does not have any interpolated variables

Module blenderproc.python.loader.HavenEnvironmentLoader (blenderproc/python/loader/HavenEnvironmentLoader.py)

Line Col. Type Symbol ID Obj Message
8 0 convention wrong-import-order C0411
standard import "from typing import Union" should be placed before "import numpy as np"
15 78 convention trailing-whitespace C0303
Trailing whitespace
15 0 warning dangerous-default-value W0102 set_world_background_hdr_img
Dangerous default value [] as argument
44 0 convention trailing-whitespace C0303
Trailing whitespace
46 49 convention trailing-whitespace C0303
Trailing whitespace
48 0 convention trailing-whitespace C0303
Trailing whitespace
54 0 convention trailing-whitespace C0303
Trailing whitespace

Module blenderproc.python.utility.GlobalStorage (blenderproc/python/utility/GlobalStorage.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
4 0 refactor useless-object-inheritance R0205 GlobalStorage
Class 'GlobalStorage' inherits from object, can be safely removed from bases in python3
13 0 convention line-too-long C0301
Line too long (121/120)
63 35 convention consider-using-f-string C0209 GlobalStorage.init_global
Formatting a regular string which could be a f-string
79 35 convention consider-using-f-string C0209 GlobalStorage.add_to_config_before_init
Formatting a regular string which could be a f-string
98 22 convention consider-iterating-dictionary C0201 GlobalStorage.add
Consider iterating the dictionary directly instead of calling .keys()
101 31 convention consider-using-f-string C0209 GlobalStorage.add
Formatting a regular string which could be a f-string
102 0 convention line-too-long C0301
Line too long (129/120)
128 8 refactor no-else-return R1705 GlobalStorage.get
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
131 31 convention consider-using-f-string C0209 GlobalStorage.get
Formatting a regular string which could be a f-string
151 8 refactor no-else-return R1705 GlobalStorage.has_param
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
166 8 refactor no-else-return R1705 GlobalStorage.get_global_config
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it

Module blenderproc.python.utility.InstallUtility (blenderproc/python/utility/InstallUtility.py)

Line Col. Type Symbol ID Obj Message
33 39 warning unused-argument W0613 InstallUtility.determine_blender_install_path
Unused argument 'user_args'

Module blenderproc.python.utility.MaterialGetter (blenderproc/python/utility/MaterialGetter.py)

Line Col. Type Symbol ID Obj Message
1 0 convention missing-module-docstring C0114
Missing module docstring
9 0 convention missing-class-docstring C0115 MaterialGetter
Missing class docstring
10 0 convention trailing-whitespace C0303
Trailing whitespace
54 44 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
57 0 convention line-too-long C0301
Line too long (129/120)
64 0 convention line-too-long C0301
Line too long (126/120)
72 40 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
81 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
85 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
89 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
93 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
104 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
108 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
112 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
116 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
138 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string
150 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
154 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
158 0 convention superfluous-parens C0325
Unnecessary parens after 'not' keyword
162 48 convention consider-using-f-string C0209 MaterialGetter.perform_and_condition_check
Formatting a regular string which could be a f-string

Module blenderproc.python.utility.Utility (blenderproc/python/utility/Utility.py)

Line Col. Type Symbol ID Obj Message
12 0 warning unused-import W0611
Unused import importlib

Module blenderproc.python.writer.BopWriterUtility (blenderproc/python/writer/BopWriterUtility.py)

Line Col. Type Symbol ID Obj Message
7 0 warning unused-import W0611
Unused import shutil
18 0 warning unused-import W0611
Unused Utility imported from blenderproc.python.utility.Utility
18 0 warning unused-import W0611
Unused resolve_path imported from blenderproc.python.utility.Utility
19 0 warning unused-import W0611
Unused dist2depth imported from blenderproc.python.postprocessing.PostProcessingUtility

Module blenderproc.python.writer.CocoWriterUtility (blenderproc/python/writer/CocoWriterUtility.py)

Line Col. Type Symbol ID Obj Message
16 0 warning unused-import W0611
Unused Utility imported from blenderproc.python.utility.Utility
91 22 error undefined-variable E0602 write_coco_annotations
Undefined variable 'segcolormap_output'
99 29 error undefined-variable E0602 write_coco_annotations
Undefined variable 'segmentation_map_output'
122 26 error undefined-variable E0602 write_coco_annotations
Undefined variable 'rgb_output'
124 75 error undefined-variable E0602 write_coco_annotations
Undefined variable 'rgb_output'

Module blenderproc.scripts.download_haven (blenderproc/scripts/download_haven.py)

Line Col. Type Symbol ID Obj Message
89 23 warning broad-exception-caught W0718 cli.download_items
Catching too general exception Exception

Metrics

Count per types

Name Count
warning 11
convention 34
refactor 4
error 4

Count per messages

Name Count
unused-import 7
trailing-whitespace 6
dangerous-default-value 1
wrong-import-order 1
f-string-without-interpolation 1
line-too-long 4
missing-module-docstring 2
useless-object-inheritance 1
consider-using-f-string 10
consider-iterating-dictionary 1
no-else-return 3
unused-argument 1
superfluous-parens 9
missing-class-docstring 1
undefined-variable 4
broad-exception-caught 1

Count per modules

Name Count
blenderproc.debug_startup 1
blenderproc.python.loader.HavenEnvironmentLoader 7
blenderproc.python.loader.BopLoader 1
blenderproc.python.utility.GlobalStorage 12
blenderproc.python.utility.InstallUtility 1
blenderproc.python.utility.MaterialGetter 20
blenderproc.python.utility.Utility 1
blenderproc.python.writer.BopWriterUtility 4
blenderproc.python.writer.CocoWriterUtility 5
blenderproc.scripts.download_haven 1

Count per path

Name Count
blenderproc/debug_startup.py 1
blenderproc/python/loader/HavenEnvironmentLoader.py 7
blenderproc/python/loader/BopLoader.py 1
blenderproc/python/utility/GlobalStorage.py 12
blenderproc/python/utility/InstallUtility.py 1
blenderproc/python/utility/MaterialGetter.py 20
blenderproc/python/utility/Utility.py 1
blenderproc/python/writer/BopWriterUtility.py 4
blenderproc/python/writer/CocoWriterUtility.py 5
blenderproc/scripts/download_haven.py 1
***The tests are done.*** Check the log:

Last update: 08/22/2023, 00:31:37

@cornerfarmer cornerfarmer merged commit 3c2cc1f into main Aug 21, 2023
2 checks passed
@cornerfarmer cornerfarmer deleted the iss_684_optical_flow_fix_rgb_key branch August 21, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: wrong backward optical flow when set output_format to OPEN_EXR
1 participant