Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gha): improve ci #134

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

aldbr
Copy link
Collaborator

@aldbr aldbr commented May 16, 2024

  • Add release-please in the loop: each push to main generates a PR which updates the changelog based on the latest commits (need to follow the conventional commit rules to work), and bumps the package version (prereleases). Once the PR is merged, a new tag/release is created, and a new image is pushed to the registry.
  • Add commitlint to make sure the commits are following conventional commit rules.
  • Edit the README.

Example of a generated tag: https://github.com/aldbr/diracx-web/releases/tag/v0.1.0-a1
Example of a generated release: https://github.com/aldbr/diracx-web/releases (a lot of useless info here but expected for the 1st release. Note that we could edit the changelog within the merged PRs but they would need to be squashed, see https://github.com/googleapis/release-please?tab=readme-ov-file#how-can-i-fix-release-notes)

And the generated images: https://github.com/aldbr/diracx-web/pkgs/container/diracx-web%2Fstatic

Why release-please?

  1. it could work with both python and node projects
  2. it provides a good balance of automation and ease of use
  3. it can handle multi-package repositories

@fstagni
Copy link
Contributor

fstagni commented May 16, 2024

I will look into the details later on, but these are things that, if applied, should not be done for only diracx-web. I am not saying to apply to DIRAC, but at least to diracx.

@fstagni fstagni merged commit 001be55 into DIRACGrid:main Jun 24, 2024
7 checks passed
@aldbr aldbr assigned aldbr and unassigned fstagni, chaen and chrisburr Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants