Skip to content

Commit

Permalink
fix: apply PR suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
Loxeris committed Jul 17, 2024
1 parent e0c72ad commit 6b00fc0
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 21 deletions.
39 changes: 20 additions & 19 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,26 @@ jobs:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
run: npx lerna publish from-package --no-push --no-private --yes

build-deploy-storybook-docs:
runs-on: ubuntu-latest
permissions:
id-token: write
pages: write
if: ${{ github.event_name == 'push' && github.repository == 'DIRACGrid/diracx-web' && github.ref_name == 'main'}}
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: 'latest'
cache: 'npm'

- uses: bitovi/[email protected]
with:
build_command: npm run build-storybook -w @dirac-grid/diracx-web-components
path: packages/diracx-web-components/storybook-static
checkout: false

build-deploy-dev-image:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'push' || github.repository == 'DIRACGrid/diracx-web' }}
Expand Down Expand Up @@ -106,22 +126,3 @@ jobs:
push: true
tags: ghcr.io/diracgrid/diracx-web/static:${{ needs.release-please.outputs.tag_name }}
platforms: linux/amd64,linux/arm64

build-deploy-storybook-docs:
runs-on: ubuntu-latest
permissions:
id-token: write
pages: write
if: ${{ github.event_name == 'push' && github.repository == 'DIRACGrid/diracx-web' && github.ref_name == 'main'}}
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: 'latest'

- uses: bitovi/[email protected]
with:
build_command: npm run build-storybook -w @dirac-grid/diracx-web-components
path: packages/diracx-web-components/storybook-static
checkout: false
2 changes: 1 addition & 1 deletion .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Clone source
run: |
cd ..
git clone https://github.com/Loxeris/diracx-charts.git -b "feat_diracx-web-port-env-&-node-modules-size"
git clone https://github.com/DIRACGrid/diracx-charts.git
- name: Start demo
run: |
cd ..
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,4 @@
* update node image ([69320e6](https://github.com/DIRACGrid/diracx-web/commit/69320e649f732f73ab5d55d0f5c84fdd948117ce))
* warning about component update ([ef26658](https://github.com/DIRACGrid/diracx-web/commit/ef26658facac4f2f93eab55d916eca3445c0cf9b))
* warnings in the CI ([ddfbb2d](https://github.com/DIRACGrid/diracx-web/commit/ddfbb2dc2774409121d0c3bc3ff732fcbff314d3))
* white button on white background ([e640b9d](https://github.com/DIRACGrid/diracx-web/commit/e640b9dfc28a25672bd07658e7976c214bc0553e))
* white button on white background ([e640b9d](https://github.com/DIRACGrid/diracx-web/commit/e640b9dfc28a25672bd07658e7976c214bc0553e))

0 comments on commit 6b00fc0

Please sign in to comment.