Do an proper editable install of mounted Python packages #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
force-pushed
the
editable-dev-install
branch
7 times, most recently
from
141441b
to
8011bdf
Compare
chrisburr
force-pushed
the
editable-dev-install
branch
from
8011bdf
to
a285ebe
Compare
chaen
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to handle metadata changes like adding new routers/databases without having a chicken-and-egg problem between the DiracX container image and this repository. See #35 for a little more detail.
It does this by always overriding the DiracX container's entrypoint to optionally add
pip install -e .... This also means we have to fully define the uvicorn command inside this chart, however I think this is desirable as we'll soon want to have other deployments using the same image (e.g. celery workers).Closes #35.