Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated webpack #164

Merged
merged 2 commits into from
Feb 24, 2019
Merged

updated webpack #164

merged 2 commits into from
Feb 24, 2019

Conversation

debragail
Copy link
Contributor

Solves #163

Updated outdated package.json and webpack.config

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • [x ] Enhancement that improves upon existing functionality

Checklist:

  • [ x] My code follows the code style of this project.
  • [ x] My change requires a change to the documentation.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@debragail debragail merged commit 3733257 into DAVFoundation:master Feb 24, 2019
@mariolo1985
Copy link

Thanks for making these changes @debragail. Could you verify that Travis builds successfully before merging your changes and work on one type of changes at a time for a PR? Travis failed for this PR.

It looks like the React components added could be written as a pure function with prop defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants