Rework Model, Dataset and Document models to use the same underlying dkg #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DKG representation Using the `DKG` representation for groundings instead of `Identifier`. Note I'm not going to go through the effort of renaming the fields from `identifier` as it will require a migration and substantial front end renaming which feels like a lot of effort for 0 gain.
Tom-Szendrey
approved these changes
Nov 12, 2024
dvince2
deleted the
5468-rework-model-dataset-and-document-models-to-use-the-same-underlying-dkg-representation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the
DKGrepresentation for groundings instead ofIdentifier. Note I'm not going to go through the effort of renaming the fields fromidentifieras it will require a migration and substantial front end renaming which feels like a lot of effort for 0 gain.Resolves #5468