Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5414 hook up local dev to static es index on s3 #5451

Merged
merged 15 commits into from
Nov 11, 2024
Merged

5414 hook up local dev to static es index on s3 #5451

merged 15 commits into from
Nov 11, 2024

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Nov 11, 2024

Description

  • Checking for the existence of an index.
  • If one is not found [this would only be in the case of local] its made then populated.
  • The mapping and data come from a static dump on s3 (actual s3 not a local minio)
  • Based off of pantera's implementation

Resolves #5414

@dvince2 dvince2 requested a review from kbirk November 11, 2024 15:50
@dvince2 dvince2 linked an issue Nov 11, 2024 that may be closed by this pull request
Hook up local dev to static ES index on S3 #5414
Closed
YohannParis
YohannParis approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is still above my head. I understand what is happening, but I'm not sure about some naming convention that makes it hard to read.

...main/java/software/uncharted/terarium/hmiserver/service/s3/DownloadStaticESIndexService.java Show resolved Hide resolved
...main/java/software/uncharted/terarium/hmiserver/service/s3/DownloadStaticESIndexService.java Show resolved Hide resolved
@dvince2 dvince2 merged commit c04906f into main Nov 11, 2024
@dvince2 dvince2 deleted the 5414-hook-up-local-dev-to-static-es-index-on-s3 branch November 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbirk kbirk kbirk approved these changes

@YohannParis YohannParis YohannParis approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees

@dgauldie dgauldie

@kbirk kbirk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hook up local dev to static ES index on S3
4 participants
@dvince2 @YohannParis @kbirk @dgauldie