This PR adds support for RegNets and Stock and Flow models to the SciML Service. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshday
requested changes
Jan 24, 2024
|
This passes tests now, including the ones I set up to test the stockflow and regnet functionality. |
joshday
approved these changes
Jan 24, 2024
This was referenced Jan 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issues #120 and #118.
This is a bit of a "temporary" solution, used while the modeling and intertypes are still being fleshed out. Eventually I think that we will want the interface to every type of model including decapodes, to be from the same place. For now though, I've created ACSets for StockFlow and RegNets that hold all of the information needed to create an MTK model. JSON AMR models get parsed in to these ACSets, which are then turned in to MTK models. This is kind of like what I'm anticipation will happen for every type of model in the future, i.e. JSON -> ACSet -> MTK. The way this is implemented will probably change in the future, but this gets it working for now.