Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to tstep and timestamp shouldn't be implemented yet #151

Merged
merged 2 commits into from
Dec 7, 2023
Merged

changes to tstep and timestamp shouldn't be implemented yet #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73b3309
timestamp not implemented in simulation-integration yet
jClugstor Dec 6, 2023
9248170
Merge branch 'main' into jClugstor-patch-1
jClugstor Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/SimulationService.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,11 +417,6 @@ function get_dataset(obj::JSON3.Object)
s3_url = get_json(tds_url).url
df = CSV.read(download(s3_url), DataFrame)

# there should always be a mapping from the dataset timestamp column name to 'timestamp'
if !any(v -> v == "timestamp", values(obj.mappings))
@warn "Expected mapping from <dataset timestamp column> to 'timestamp' not provided"
end

for (k,v) in get(obj, :mappings, Dict())
@info "`get_dataset` (dataset id=$(repr(obj.id))) rename! $k => $v"
if k != "tstep"
Expand Down
Loading