Inter results fixes #138
Merged
Inter results fixes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of an optimization step at the timestamps from the data.
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 75.00% 76.37% +1.37%
==========================================
Files 3 3
Lines 440 453 +13
==========================================
+ Hits 330 346 +16
+ Misses 110 107 -3
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
joshday
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the solution of the DE at every optimization step is reported at the time stamps of the calibration data with the intermediate results. (This assumes that every state is sampled at the same timestep in the data, which is true for all of the scenarios so far.)