Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Ensemble and some other fixes #103

Merged
merged 10 commits into from
Jul 19, 2023
Merged

WIP Ensemble and some other fixes #103

merged 10 commits into from
Jul 19, 2023

Conversation

joshday
Copy link
Collaborator

@joshday joshday commented Jul 19, 2023

  • Fixed result_files to return filename rather than s3 bucket url
  • handle both "timestep" and "timestamp" fields in data.
  • Minor cleanup
  • A start on ensemble

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #103 (993adab) into main (05063a3) will increase coverage by 0.27%.
The diff coverage is 58.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   78.37%   78.64%   +0.27%     
==========================================
  Files           3        3              
  Lines         356      384      +28     
==========================================
+ Hits          279      302      +23     
- Misses         77       82       +5     
Impacted Files Coverage Δ
src/SimulationService.jl 71.10% <57.57%> (-0.13%) ⬇️
src/operations.jl 88.48% <59.45%> (-0.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 13e8715 into main Jul 19, 2023
2 checks passed
@ChrisRackauckas ChrisRackauckas deleted the jd/ensemble branch July 19, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants