Detector: Cache array length #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy cli/reportgen
heuristics to link state variables and storage pointers part 1 heuristics to link state variables and storage pointers part 2 heuristics to link state variables and storage pointers part 3
checkpoint 2 checkpoint 2 checkpoint 3 checkpoint 3 checkpoint 3
TilakMaddy
changed the title
TilakMaddy
changed the base branch from
feature/extract-written-state-variables
to
dev
TilakMaddy
changed the title
alexroan
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severity: Low
Qualifications: All solc versions
Logic:
Scan every for loop. Look inside the condition for any references to the
lengthproperty of a storage variable array. Gather all those storage variables.Now, look inside the for loop (investigate with callgraph) completely and see if any of those storage variable arrays gathered above, are being mutated. If yes, then there is no scope for caching the length outside. Once you ensure none of those storage variables are being mutated capture the for loop as a potential optimization opportunity