Detector: Incorrect ERC721 contract #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TilakMaddy
commented
Aug 5, 2024
alexroan
reviewed
Aug 9, 2024
alexroan
requested changes
Aug 12, 2024
There was a problem hiding this comment.
This detector should focus only on ERC721 interface. #655 (comment)
alexroan
approved these changes
Aug 16, 2024
TilakMaddy
added a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Alex Roan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severity: High
We look for ERC721 method signatures on contract that are deemed to be ERC721 (by looking at the names of inheritance heirarchy)
Then, if a function signature matches, but the function itself does not return what it's supposed to return according to the ERC721 spec we capture it