state change hint

Cyfrin · Oct 6, 2024 · a8117c8 · a8117c8
1 parent ba94a0b
commit a8117c8
Show file tree

Hide file tree

Showing 6 changed files with 80 additions and 8 deletions.
diff --git a/aderyn_core/src/detect/high/state_change_after_ext_call.rs b/aderyn_core/src/detect/high/state_change_after_ext_call.rs
@@ -3,7 +3,7 @@ use std::{
     error::Error,
 };
 
-use crate::ast::NodeID;
+use crate::{ast::NodeID, context::browser::Peek};
 
 use crate::{
     capture,
@@ -58,7 +58,20 @@ impl IssueDetector for StateChangeAfterExternalCallDetector {
                         if let Some(external_call_ast_node) =
                             external_call_cfg_node.reflect(context)
                         {
-                            capture!(self, context, external_call_ast_node);
+                            let state_change_cfg_node =
+                                cfg.nodes.get(&state_change).expect("cfg is corrupted");
+
+                            if let Some(state_change_ast_node) =
+                                state_change_cfg_node.reflect(context)
+                            {
+                                if let Some(state_change_code) = state_change_ast_node.peek(context)
+                                {
+                                    let hint =
+                                        format!("State is changed at: `{}`", state_change_code);
+
+                                    capture!(self, context, external_call_ast_node, hint);
+                                }
+                            }
                         }
                     }
                 }

diff --git a/reports/ccip-functions-report.md b/reports/ccip-functions-report.md
diff --git a/reports/report.json b/reports/report.json
diff --git a/reports/report.md b/reports/report.md
diff --git a/reports/report.sarif b/reports/report.sarif
diff --git a/reports/templegold-report.md b/reports/templegold-report.md