feat: Add automatic detection of output format from filename #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented logic to detect the output format from the output filename extension. - If `-fn` is set but `--json` or `--bom-format` are not set, the format is determined based on the file extension. - Supported extensions: .xml, .json, .proto, .pb, .bin. - Explicit parameters `--json` or `--bom-format` take precedence if set. Signed-off-by: Michael Tsfoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a feature to automatically detect the output format based on the provided output filename's extension. If the
-fn(or--filename) option is set but--jsonor the future--bom-formatoption is not set, the format is derived from the file extension. Explicit parameters--jsonor--bom-formatwill take precedence if set.Changes
SetOutputFormatFromFilenameinRunner.csto determine the format from the file extension..xml,.json,.proto,.pb,.bin.HandleCommandAsyncmethod ofRunner.cs.Testing
Related Issues
Please review the changes and provide feedback.