fix: Add additional log context when reference can not be found #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any fix for this one? |
|
Hello shawner18, I'd like to merge this, but the sign-off is missing. See here: https://github.com/CycloneDX/cyclonedx-dotnet/pull/662/checks?check_run_id=11826932593 |
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
shawner18
force-pushed
the
unable-to-locate-bom-ref-logging
branch
from
ab07875
to
fb008ba
Compare
Done, sorry about that |
mtsfoni
requested changes
Sep 28, 2023
Signed-off-by: [email protected] <[email protected]>
…/shawner18/cyclonedx-dotnet into unable-to-locate-bom-ref-logging
mtsfoni
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where the BOM was failing to generate due to dependency resolution issues. The current logging was not clear enough to identify the source of the issue, since we had many projects and many dependencies.
Original output
Dependency ([2.29.0, )) with version range ([2.29.0, )) did not resolve to a specific version.
Unable to locate valid bom ref for my.library [2.29.0, )
Enhanced output
Dependency (my.library) with version range ([2.29.0, )) referenced by (Name:my.other.library Version:1.18.26) in did not resolve to a specific version.
Unable to locate valid bom ref for my.library [2.29.0, ) referenced in (Name: my.other.library Version: 1.18.26)