qa: replace PHPStan ignore annotation by phpstan-assert-if-true

CuyZ · Apr 4, 2024 · 4e04201 · 4e04201
1 parent c4be758
commit 4e04201
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/Type/Parser/Lexer/Token/ObjectToken.php b/src/Type/Parser/Lexer/Token/ObjectToken.php
@@ -19,7 +19,7 @@ public function __construct(
     public function traverse(TokenStream $stream): Type
     {
         return Reflection::enumExists($this->className)
-            ? (new EnumNameToken($this->className))->traverse($stream) // @phpstan-ignore-line / We know `$this->className` matches `class-string<UnitEnum>`
+            ? (new EnumNameToken($this->className))->traverse($stream)
             : (new ClassNameToken($this->className))->traverse($stream);
     }
 

diff --git a/src/Type/Parser/Lexer/Token/VacantToken.php b/src/Type/Parser/Lexer/Token/VacantToken.php
@@ -32,12 +32,10 @@ public function traverse(TokenStream $stream): Type
         }
 
         if (Reflection::enumExists($this->symbol)) {
-            // @phpstan-ignore-next-line / We know `$this->symbol` matches `class-string<UnitEnum>`
             return (new EnumNameToken($this->symbol))->traverse($stream);
         }
 
         if (Reflection::classOrInterfaceExists($this->symbol)) {
-            // @phpstan-ignore-next-line / We know `$this->symbol` matches `class-string`
             return (new ClassNameToken($this->symbol))->traverse($stream);
         }
 

diff --git a/src/Utility/Reflection/Reflection.php b/src/Utility/Reflection/Reflection.php
@@ -19,6 +19,7 @@
 use ReflectionType;
 use ReflectionUnionType;
 use Reflector;
+use UnitEnum;
 
 use function array_filter;
 use function array_map;
@@ -47,6 +48,8 @@ final class Reflection
 
     /**
      * Case-sensitive implementation of `class_exists` and `interface_exists`.
+     *
+     * @phpstan-assert-if-true class-string $name
      */
     public static function classOrInterfaceExists(string $name): bool
     {
@@ -55,6 +58,9 @@ public static function classOrInterfaceExists(string $name): bool
             && self::class($name)->name === ltrim($name, '\\');
     }
 
+    /**
+     * @phpstan-assert-if-true class-string<UnitEnum> $name
+     */
     public static function enumExists(string $name): bool
     {
         // @infection-ignore-all / We don't need to test the cache