Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unsafe eval code from bundle #118

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Feb 22, 2023

Explanation

Remove unsafe eval code which comes from snarkjs > ejs.

More Information

Related to discussions in #116

Screenshots/Screencaps

N/A

Manual Testing Steps

Should load/generate proofs as expected without CSP errors

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

PR template source from github.com/MetaMask

@0xmad 0xmad added this to the Successful Beta v0.0.1 Release milestone Feb 22, 2023
@0xmad 0xmad requested a review from 0xisk February 22, 2023 20:23
@0xmad 0xmad self-assigned this Feb 22, 2023
@0xmad 0xmad added the 🛡️security Troubleshooting security issues label Feb 22, 2023
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, just some small points left then we can good to go for approval.
Also, regarding ejs we can uninstall @zk-kit/protocols from the package.json, since it depends also on snarks and we dont need it anyway.

src/config/ejsMock.js Show resolved Hide resolved
webpack.common.js Show resolved Hide resolved
package.json Show resolved Hide resolved
@0xmad 0xmad requested a review from 0xisk February 23, 2023 14:46
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @0xmad

@0xisk 0xisk merged commit a18671c into master Feb 23, 2023
@0xisk 0xisk deleted the chore/remove-unsafe-eval branch February 23, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛡️security Troubleshooting security issues
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants