Added splunk fwdtype and os details to the device inventory #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VatsalJagani
requested changes
Jun 20, 2024
| @@ -209,7 +213,7 @@ require([ | |||
| | eval _time=strftime(latest_time, "%F %T") | |||
| | eval Select="CHECKBOX_THIS_".uuid | |||
| | rename ips as ip, hostnames as hostname, mac_addresses as mac_address | |||
| | table uuid, Select, _time, ip, hostname, mac_address, lansweeper_id, lansweeper_state, lansweeper_asset_type, lansweeper_os, lansweeper_user, lansweeper_description, qualys_id, QUALYS_OS, qualys_network_id, tenable_uuid, tenable_os, nessus_uuid, nessus_os, sophos_uuid, sophos_type, sophos_os, sophos_user, sophos_login_via, sophos_health, sophos_product_installed, crowdstrike_id,kaspersky_collected_by,kaspersky_version,kaspersky_host, kaspersky_status windows_defender_host | |||
| | table uuid, Select, _time, ip, hostname, mac_address, lansweeper_id, lansweeper_state, lansweeper_asset_type, lansweeper_os, lansweeper_user, lansweeper_description, qualys_id, QUALYS_OS, qualys_network_id, tenable_uuid, tenable_os, nessus_uuid, nessus_os, sophos_uuid, sophos_type, sophos_os, sophos_user, sophos_login_via, sophos_health, sophos_product_installed, crowdstrike_id,kaspersky_collected_by,kaspersky_version,kaspersky_host, kaspersky_status, windows_defender_host, splunk_host, splunk_os, splunk_user, splunk_version, splunk_forwarder_type, splunk_server | |||
There was a problem hiding this comment.
Do we need splunk_server?
What's the value for splunk_user? Is it multi-valued field?
There was a problem hiding this comment.
splunk_server is not much useful as we have hostname hence removing it.
I forgot to remove splunk_user from here as no such info available. I'll remove it.
| @@ -239,12 +243,15 @@ definition = cyencesdevicemanager operation="getdevices" \ | |||
| | eval kaspersky_status=kaspersky_status \ | |||
| | eval tmp_kaspersky_status = kaspersky_status, kaspersky=case(tmp_kaspersky_status == "Present", 0, tmp_kaspersky_status == "Disabled", 1) \ | |||
| | fieldformat kaspersky=tmp_kaspersky_status \ | |||
| | eval splunk_status=case(isnull(splunk_last_event), "-", 1==1, splunk_forwarder_type) \ | |||
There was a problem hiding this comment.
splunk_status word is misleading as one would expect to have up/down status.
Instead we can say splunk_type maybe.
There was a problem hiding this comment.
Shall we add this as a separate table to show all the Splunk related fields?
There was a problem hiding this comment.
Sure, will add same as other product table to show/hide when it's related to splunk.
VatsalJagani
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.