Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and improvement in file sharing alert. #562

Merged
merged 2 commits into from
May 30, 2024
Merged

Bug fixes and improvement in file sharing alert. #562

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b881ddd
Bug fixes and improvement in file sharing alert.
VatsalJagani May 17, 2024
826fea2
Merge branch 'master' into bug-fix-file-sharing
VatsalJagani May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions cyences_app_for_splunk/default/data/ui/views/cs_o365_reports.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,13 +1030,13 @@
| iplocation ClientIP
| fillnull value="" Country, Region, City
| rename ClientIP as Source
| stats values(Operation) as Operations, values(EventData) as EventData, values(Source) as Source, values(SharingLinkScope) as SharingLinkScope, values(Permission) as Permission, values(ItemType) as ItemType, values(ApplicationDisplayName) as ApplicationDisplayName, values(EventSource) as EventSource latest(_time) as LastTime earliest(_time) as FirstTime, values(Country) as Country, values(City) as City, values(Region) as Region by SourceFileName, UserId
| search SharingLinkScope!="Organization"
| stats values(Operation) as Operations, values(TargetUserOrGroupName) as TargetUserOrGroupName, values(EventData) as EventData, values(ObjectId) as ObjectId, values(Source) as Source, values(SharingLinkScope) as SharingLinkScope, values(Permission) as Permission, values(ItemType) as ItemType, values(ApplicationDisplayName) as ApplicationDisplayName, values(EventSource) as EventSource latest(_time) as LastTime earliest(_time) as FirstTime, values(Country) as Country, values(City) as City, values(Region) as Region by SourceFileName, UserId
| search NOT SharingLinkScope="Organization"
| rename UserId as User
| `cs_human_readable_time_format(FirstTime)`
| `cs_human_readable_time_format(LastTime)`
| `cs_user_privilege_mapping(User)`
| table User,is_privileged_user,SourceFileName,SharingLinkScope,Permission,EventSource,ItemType,Operations,ApplicationDisplayName,FirstTime,LastTime,EventData,Source,Country,City,Region
| table User,is_privileged_user,SourceFileName,SharingLinkScope,Permission,TargetUserOrGroupName,EventSource,ItemType,Operations,ApplicationDisplayName,FirstTime,LastTime,EventData,ObjectId,Source,Country,City,Region
| `cs_o365_sharing_file_with_external_user_filter`
</query>
<earliest>$timeRange.earliest$</earliest>
Expand Down Expand Up @@ -1082,12 +1082,14 @@
</input>
<table>
<search>
<query>`cs_o365` sourcetype="o365:management:activity" Workload IN (OneDrive, SharePoint) Operation IN ("AnonymousLinkUsed","SharingLinkUsed") NOT TargetUserOrGroupType IN ("Member", "SharePointGroup") $tkn_exclude_teams_link_accessed$ $tkn_application_name_link_accessed$
| search UserId=anonymous
| iplocation ClientIP
<query>`cs_o365` sourcetype="o365:management:activity" Workload IN (OneDrive, SharePoint) Operation IN ("AnonymousLinkUsed","SharingLinkUsed") $tkn_exclude_teams_link_accessed$ $tkn_application_name_link_accessed$
| iplocation ClientIP
| fillnull value="" Country, Region, City
| rename ClientIP as Source
| stats values(Operation) AS Operations, values(ObjectId) as ObjectId , values(SharingLinkScope) as SharingLinkScope, values(Permission) as Permission, values(ApplicationDisplayName) as ApplicationDisplayName, values(Source) as Source,values(EventData) as EventData, values(ItemType) as ItemType,values(EventSource) as EventSource latest(_time) as LastTime earliest(_time) as FirstTime, values(Country) as Country, values(City) as City, values(Region) as Region by SourceFileName, UserId
| stats values(Operation) AS Operations, values(ObjectId) as ObjectId , values(SharingLinkScope) as SharingLinkScope, values(Permission) as Permission, values(ApplicationDisplayName) as ApplicationDisplayName, values(Source) as Source,values(EventData) as EventData, values(ItemType) as ItemType,values(EventSource) as EventSource latest(_time) as LastTime earliest(_time) as FirstTime, values(Country) as Country, values(City) as City, values(Region) as Region by SourceFileName, UserId
| rex field=UserId "(?&lt;email_user&gt;[^@]+)@(?&lt;email_domain&gt;.+)"
| eval email_domain_search = replace(email_domain, "\.", "_") | fillnull value="NOTHING_HERE_NO" email_domain_search
| search NOT SharingLinkScope="Organization" | where !like(ObjectId, "%".email_domain_search."%")
| rename UserId as UserAccessingFile
| `cs_human_readable_time_format(FirstTime)`
| `cs_human_readable_time_format(LastTime)`
Expand Down
12 changes: 7 additions & 5 deletions cyences_app_for_splunk/default/savedsearches.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2806,14 +2806,14 @@ search = `cs_o365` sourcetype="o365:management:activity" _index_earliest=-61m@m
| iplocation ClientIP \
| fillnull value="" Country, Region, City \
| rename ClientIP as Source \
| stats values(Operation) as Operations, values(EventData) as EventData, values(Source) as Source, values(SharingLinkScope) as SharingLinkScope, values(Permission) as Permission, values(ItemType) as ItemType, values(ApplicationDisplayName) as ApplicationDisplayName, values(EventSource) as EventSource latest(_time) as LastTime earliest(_time) as FirstTime, values(Country) as Country, values(City) as City, values(Region) as Region by SourceFileName, UserId \
| search SharingLinkScope!="Organization" \
| stats values(Operation) as Operations, values(TargetUserOrGroupName) as TargetUserOrGroupName, values(EventData) as EventData, values(ObjectId) as ObjectId, values(Source) as Source, values(SharingLinkScope) as SharingLinkScope, values(Permission) as Permission, values(ItemType) as ItemType, values(ApplicationDisplayName) as ApplicationDisplayName, values(EventSource) as EventSource latest(_time) as LastTime earliest(_time) as FirstTime, values(Country) as Country, values(City) as City, values(Region) as Region by SourceFileName, UserId \
| search NOT SharingLinkScope="Organization" \
| rename UserId as User \
| `cs_human_readable_time_format(FirstTime)` \
| `cs_human_readable_time_format(LastTime)` \
| `cs_user_privilege_mapping(User)` \
| eval cyences_severity = if(is_privileged_user=="Yes", "critical","high") \
| table User,is_privileged_user,SourceFileName,Permission,SharingLinkScope,EventSource,ItemType,Operations,ApplicationDisplayName,FirstTime,LastTime,EventData,cyences_severity,Source,Country,Region \
| table User,is_privileged_user,SourceFileName,Permission,SharingLinkScope,TargetUserOrGroupName,EventSource,ItemType,Operations,ApplicationDisplayName,FirstTime,LastTime,EventData,ObjectId,cyences_severity,Source,Country,Region \
| `cs_o365_sharing_file_with_external_user_filter`
action.cyences_notable_event_action = 1
action.cyences_notable_event_action.param.filter_macro_name = cs_o365_sharing_file_with_external_user_filter
Expand Down Expand Up @@ -2841,13 +2841,15 @@ display.page.search.tab = statistics
display.page.search.mode = fast
request.ui_dispatch_app = cyences_app_for_splunk
request.ui_dispatch_view = search
search = `cs_o365` sourcetype="o365:management:activity" _index_earliest=-61m@m _index_latest=-1m@m Workload IN (OneDrive, SharePoint) Operation IN ("AnonymousLinkUsed","SharingLinkUsed") NOT TargetUserOrGroupType IN ("Member", "SharePointGroup") \
search = `cs_o365` sourcetype="o365:management:activity" _index_earliest=-61m@m _index_latest=-1m@m Workload IN (OneDrive, SharePoint) Operation IN ("AnonymousLinkUsed","SharingLinkUsed") \
|`cs_o365_link_accessed_by_external_user_internal_filter` \
| search UserId=anonymous \
| iplocation ClientIP \
| fillnull value="" Country, Region, City \
| rename ClientIP as Source \
| stats values(Operation) as Operations, values(ObjectId) as ObjectId , values(SharingLinkScope) as SharingLinkScope, values(Permission) as Permission, values(ApplicationDisplayName) as ApplicationDisplayName, values(Source) as Source,values(EventData) as EventData, values(ItemType) as ItemType,values(EventSource) as EventSource latest(_time) as LastTime earliest(_time) as FirstTime, values(Country) as Country, values(City) as City, values(Region) as Region by SourceFileName, UserId \
| rex field=UserId "(?<email_user>[^@]+)@(?<email_domain>.+)" \
| eval email_domain_search = replace(email_domain, "\.", "_") | fillnull value="NOTHING_HERE_NO" email_domain_search \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic seems it's ignoring all event which has email domain in UserId field. It is not validating which domain it is.

I think it will do similar to the following filter:
| search UserId=anonymous
| search NOT SharingLinkScope="Organization"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| where !like(ObjectId, "%".email_domain_search."%")

This code is doing that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I was testing the search where mistakenly \ was replaced.

| search NOT SharingLinkScope="Organization" | where !like(ObjectId, "%".email_domain_search."%") \
| rename UserId as UserAccessingFile \
| `cs_human_readable_time_format(FirstTime)` \
| `cs_human_readable_time_format(LastTime)` \
Expand Down