Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cy 514 add the panel and alert for windows firewall status #341

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Cy 514 add the panel and alert for windows firewall status #341

merged 6 commits into from
Jul 27, 2023

Conversation

hardikhdholariya
Copy link
Contributor

  • Added the alert to create the notables when firewall status has been disabled from its active state.
  • Added the "Windows Firewall Status" panel to display the latest firewall status by the host.

VatsalJagani
VatsalJagani reviewed Jul 12, 2023
View reviewed changes
cyences_app_for_splunk/default/data/ui/views/cs_windows_reports.xml Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/data/ui/views/cs_windows_reports.xml Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/data/ui/views/cs_windows_reports.xml Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/savedsearches.conf Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/savedsearches.conf Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/savedsearches.conf Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/savedsearches.conf Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/savedsearches.conf Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/savedsearches.conf Outdated Show resolved Hide resolved
cyences_app_for_splunk/default/savedsearches.conf Outdated Show resolved Hide resolved
VatsalJagani
VatsalJagani reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@VatsalJagani VatsalJagani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make Overview dashboard change, similar to Sophos Service Not Running Alert.

VatsalJagani
VatsalJagani reviewed Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@VatsalJagani VatsalJagani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge this. It should be part of Cyences 4.2.0, which is the next release, hence keep this PR open until we release 4.1.0. (hence not approving till then, otherwise code change looks good.)

@hardikhdholariya hardikhdholariya merged commit 3565968 into master Jul 27, 2023
1 check passed
@VatsalJagani VatsalJagani deleted the CY-514-add-the-panel-and-alert-for-windows-firewall-status branch December 19, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VatsalJagani VatsalJagani VatsalJagani approved these changes

@mahirchavda mahirchavda Awaiting requested review from mahirchavda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardikhdholariya @VatsalJagani