Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issues with Worksite search input, add debounce + other improvements, wip recent worksites #483

Merged
merged 15 commits into from
Sep 10, 2023

Conversation

deepanchal
Copy link
Contributor

@deepanchal deepanchal commented Sep 10, 2023

Description

  • fix(comps): set getter func on watch calls with props.* as they were not running
  • refactor(comps): set emits option for WorksiteSearchInput
  • feat(models): add WorkType model
  • chore: disable typescript-eslint/member-ordering rule
  • feat(store): register WorkType model in vuex store
  • fix(models): set WorkType as work_types type in Worksite model
  • fix(comps): fix type + other issues with WorksiteSearchInput
  • refactor(comps): split onFocus into func in WorksiteSearchInput
  • fix(models): remove id and updated_at fields from Worksite model as its inherited from CCUModel
  • feat(hooks): add useRecentWorksites composable
  • fix(comps): fix issues + refactor WorksiteSearchInput
  • fix(comps): add debounce search to WorksiteSearchInput, fix types
  • feat(comps): disable recent worksites temporarily till its stable in WorksiteSearchInput
  • fix(comps): remove unwanted setTimeout from onBlur
  • refactor(comps): remove unused css from WorksiteSearchInput

Current Behavior

New Behavior

Screenshots

Related Issue

Ref: #484

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

@deepanchal deepanchal merged commit 4c43504 into master Sep 10, 2023
8 checks passed
@deepanchal deepanchal deleted the fix/work-issues-1 branch September 10, 2023 02:51
@sentry-io
Copy link

sentry-io bot commented Sep 10, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: undefined is not an object (evaluating 'Xe.data.results') worksitesSearch(src/components/work/WorksiteSea... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant