-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed Data Analysis #65
Conversation
@aditya-gupta1 Please review this |
@rutujak24 You PR is under review. Till then, kindly edit your PR description and follow this template for the same. |
All Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, Firstly nice work. I see u have covered pretty much all checkpoints suggested by @aditya-gupta1 . Now there are a couple of things to be done.
- Hide the main driving code. Codes like .head() and labelling can be kept. but codes that involve even a slight logic should be hid. Instead of the code mention a hint as a comment. But keep the output as it is. So what I suggest is after running the entire juyter notebook comment out the hints as mentioned.
I agree this is a bit painful to do bt now u have quality addition and ppl need to learn from ur code, not follow them step by step. Something like this. To save time don't document stuff but just comment the code as a hint. - Also when u download the .ipynb file kindly make sure u get rid of the errors first. The error are mainly type errors or some local package errors(right?). That may mislead or dimish the beauty of ur code.
All this should pretty much take half an hour or so. Try as much as time permits u to do.
I have also requested @aditya-gupta1 for a review, to see if you have satisfied his ideation.
Don't worry, ur contribution is quality work. Just u have to restructure it according to our motto.
Reach out to us if u have any queries.
Also, I researched u a bit and I say can u work as a creator? U have quite a stellar profile and u can make some potential contributions to microbytes. Go through some of the repos in miscellaneous to get an idea of what is expected from a creator. Maybe convert some good project of yours into a microbyte. Cheers |
Should I make a new PR with all the required changes? |
Thanks a lot for reaching out! I would love to work as a creator, please let me know the perks of it. |
@rutujak24 No need to create an new pr just simply commit changes in this pr ! |
Since I have created a new PR #66 Please evaluated it and merge it |
Hey @sudhanshutiwari264 are you asking me? I guess you have tagged wrong person out there. |
@rutujak24 It's an typo mistake ! And I apologize for editing your comment as currently I am reviewing this by phone so by mistake I have edited it ! We will review your new pr asap ! |
Alright @sudhanshutiwari264 no worries. |
@rutujak24 ! |
Hey @Kevinpaulose05 I am glad to note that you found my profile engaging, I am ready to work as a creator, wherein I will add some more projects! |
Can u create at least one by tomorrow or Monday? Coz then next week learners can have a fresh bunch of repos to work with. Cheers :) |
I will try my best @Kevinpaulose05 , should I create a new project folder? |
Hey, @rutujak24 you need to follow a set of instructions as we have posted on slack to create a MicroByte. |
Hello @amoghrajesh I will go with MySQL DATABASE, "How to learn SQL queries by operating on tables |
@rutujak24 Actually we already have a MicroByte based on MySQL in this repo. Kindly go through them before you start your work to make it as good as possible. Cheers. 🍻 |
@rutujak24 On second note, I suppose that you could go more adventurous by working on some other great idea. Based on your performance on this issue, seems like you can do an awesome job of creating something similar to which we don't have on stock already. That way you'll be doing us a huge favour, for we're looking for contributors who'll contribute quality MicroBytes. On a side note, if it's a quality MicroByte, we'll most probably showcase it on the @CrioDo website. Cheers. 🥂 |
Thanks, @Ak-Shaw for considering me for this opportunity! |
@rutujak24 Actually you are free to go wild in any manner you want, kindly do fork the correct master repo for you MicroByte though. But, remember one very important thing, kindly don't create a tutorial that's already available if a person knows how to Google. You are free to take inspiration from MicroBytes like this or this, etc. The main point being, you need to follow the @CrioDo motto by creating a MicroByte which adheres to the LearnByDoing approach. Basically the learners who use your content, should be virtually forced to think of solutions on their own, instead of it being provided to them. That is how one learns the most. Also, kindly remember that the learning time required for your MicroByte should be 1-2 hours, the reason being they're MicroBytes. Looking forward to your contributions!! 🚀 |
Done! |
Closes #39
Checklist: