Basic Mikro-e 6LoWPAN clicker support #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If5b1de77213c4889a0e3df3a8a79124202079fa1 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]> platform/mikro-e/contiki-conf.h: rename RITIMER_CLOCK_LT to RTIMER_CLOCK_DIFF to match the new define name Signed-off-by: Michal Tusnio <[email protected]>
Currently only uart pins are configured in the platform initialisation code. Change-Id: Iac6b72abb0a4654cb126c2c42e89e9bedb252a46 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]>
Change-Id: I18f6c239509e70739fcda68248051036e622fe65 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]> platform/mikro-e: fix incorrect configurations for uart pins RPF4 is Tx and RPF5 is Rx according to platform specs whereas the current code incorrectly configures F4 as Rx and F5 as Tx. Change-Id: I032f8ae811f77148c78a9f45363117b13fae8649 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]>
|
Is there any test APP we can include in the PR and use to test if the platform works? Even as simple as just printing something or flashing leds. |
|
@mtusnio the hello-world in the examples directory can act as a test app ? |
abhijit-mahajani-imgtec
suggested changes
Mar 3, 2017
There was a problem hiding this comment.
we can fix the coding style and add doxygen comments, also fix the indentation by uncrustify as mentioned in https://github.com/contiki-os/contiki/blob/master/CONTRIBUTING.md
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| /* TODO: add documentation */ |
There was a problem hiding this comment.
probably we should add documentation now
| typedef uint32_t clock_time_t; | ||
| typedef uint32_t rtimer_clock_t; | ||
|
|
||
| #define RTIMER_CLOCK_DIFF(a,b) ((int32_t)((a)-(b)) < 0) |
There was a problem hiding this comment.
Not as per uncrustify standards.
abhijit@krishna:~/work/github-abhijit/contiki$ ./tools/code-style/uncrustify-check-style.sh platform/mikro-e/contiki-conf.h
--- platform/mikro-e/contiki-conf.h 2017-03-03 12:08:37.345679550 +0530
+++ /dev/stdin 2017-03-03 12:10:19.073679201 +0530
@@ -41,7 +41,7 @@
typedef uint32_t clock_time_t;
typedef uint32_t rtimer_clock_t;
-#define RTIMER_CLOCK_DIFF(a,b) ((int32_t)((a)-(b)) < 0)
+#define RTIMER_CLOCK_DIFF(a, b) ((int32_t)((a) - (b)) < 0)
#define CLOCK_CONF_SECOND 1024
| r = process_run(); | ||
| } while(r > 0); | ||
| watchdog_stop(); | ||
| asm volatile("wait"); |
There was a problem hiding this comment.
Not as per uncrustify standards
abhijit@krishna:~/work/github-abhijit/contiki$ ./tools/code-style/uncrustify-check-style.sh platform/mikro-e/contiki-mikro-e-main.c
--- platform/mikro-e/contiki-mikro-e-main.c 2017-03-03 12:08:37.369679550 +0530
+++ /dev/stdin 2017-03-03 12:10:05.641679247 +0530
@@ -67,7 +67,7 @@
r = process_run();
} while(r > 0);
watchdog_stop();
- asm volatile("wait");
+ asm volatile ("wait");
watchdog_start();
}
|
@Avinash95 If it works with this basic support, yeah, definitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this connects #42