-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Mikro-e 6LoWPAN clicker support #74
base: basic_mikro-e_support
Are you sure you want to change the base?
Basic Mikro-e 6LoWPAN clicker support #74
Conversation
Change-Id: If5b1de77213c4889a0e3df3a8a79124202079fa1 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]> platform/mikro-e/contiki-conf.h: rename RITIMER_CLOCK_LT to RTIMER_CLOCK_DIFF to match the new define name Signed-off-by: Michal Tusnio <[email protected]>
Currently only uart pins are configured in the platform initialisation code. Change-Id: Iac6b72abb0a4654cb126c2c42e89e9bedb252a46 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]>
Change-Id: I18f6c239509e70739fcda68248051036e622fe65 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]> platform/mikro-e: fix incorrect configurations for uart pins RPF4 is Tx and RPF5 is Rx according to platform specs whereas the current code incorrectly configures F4 as Rx and F5 as Tx. Change-Id: I032f8ae811f77148c78a9f45363117b13fae8649 Signed-off-by: Rahul Daga <[email protected]> Signed-off-by: Abhijit Mahajani <[email protected]>
Is there any test APP we can include in the PR and use to test if the platform works? Even as simple as just printing something or flashing leds. |
@mtusnio the hello-world in the examples directory can act as a test app ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can fix the coding style and add doxygen comments, also fix the indentation by uncrustify as mentioned in https://github.com/contiki-os/contiki/blob/master/CONTRIBUTING.md
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
/* TODO: add documentation */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably we should add documentation now
typedef uint32_t clock_time_t; | ||
typedef uint32_t rtimer_clock_t; | ||
|
||
#define RTIMER_CLOCK_DIFF(a,b) ((int32_t)((a)-(b)) < 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as per uncrustify standards.
abhijit@krishna:~/work/github-abhijit/contiki$ ./tools/code-style/uncrustify-check-style.sh platform/mikro-e/contiki-conf.h
--- platform/mikro-e/contiki-conf.h 2017-03-03 12:08:37.345679550 +0530
+++ /dev/stdin 2017-03-03 12:10:19.073679201 +0530
@@ -41,7 +41,7 @@
typedef uint32_t clock_time_t;
typedef uint32_t rtimer_clock_t;
-#define RTIMER_CLOCK_DIFF(a,b) ((int32_t)((a)-(b)) < 0)
+#define RTIMER_CLOCK_DIFF(a, b) ((int32_t)((a) - (b)) < 0)
#define CLOCK_CONF_SECOND 1024
r = process_run(); | ||
} while(r > 0); | ||
watchdog_stop(); | ||
asm volatile("wait"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as per uncrustify standards
abhijit@krishna:~/work/github-abhijit/contiki$ ./tools/code-style/uncrustify-check-style.sh platform/mikro-e/contiki-mikro-e-main.c
--- platform/mikro-e/contiki-mikro-e-main.c 2017-03-03 12:08:37.369679550 +0530
+++ /dev/stdin 2017-03-03 12:10:05.641679247 +0530
@@ -67,7 +67,7 @@
r = process_run();
} while(r > 0);
watchdog_stop();
- asm volatile("wait");
+ asm volatile ("wait");
watchdog_start();
}
@Avinash95 If it works with this basic support, yeah, definitely. |
this connects #42