Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added node-webkit(nw) compability #760

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

skroink
Copy link

@skroink skroink commented Apr 16, 2016

In response to this thread, I've added a new file easel-nw.combined.js that supports node-webkit.

@MannyC
Copy link
Contributor

MannyC commented Apr 16, 2016

hey skroink,

you don't actually edit the files in the lib directory directly, and actually you shouldn't submit any of the changes to files in the lib folder.

Instead you change the source file (src/createjs/utils/Ticker.js in this case) and submit that. You can use grunt as explained in the build folder's readme ( here ) to concatenate the file for local testing.

If you're just adding window. before each performance, then that should in a browser too.

@skroink
Copy link
Author

skroink commented Apr 18, 2016

Thank you for your response, I'll be suggesting a commit using you guidelines.

@lannymcnie
Copy link
Member

This is definitey a request I would like to merge, however it looks like you just did a find/replace for performance, so there are a ton of doc changes that are now incorrect:

This allows the subclass to call super class methods without using function.call, providing better window.performance.

I had a fix ready to go for the reported issue, which is a little more succinct. I was going to commit it, but I think the updates to other window-level properties (document) are helpful too. If you can clean up the incorrect changes, and use the snippet below, I can review and merge this one.

    var perf = window.performance,
            now = perf && (perf.now || perf.mozNow || perf.msNow || perf.oNow || perf.webkitNow);
    Ticker._getTime = function() {
        return ((now&&now.call(perf))||(new Date().getTime())) - Ticker._startTime;
    };

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants