Final - New Events Page

[nabramow]

This is the final PR for the new events feature. The individual pieces have all already been reviewed in smaller PRs, so here we're looking for any final design or usability issues before it goes to prod.

Closes #4823

Web frontend checklist

• [ x ] Formatted my code with yarn format
• [ x ] There are no warnings from yarn lint --fix
• There are no console warnings when running the app
• Added any new components to storybook
• [ x ] Added tests where relevant
• [ x ] All tests pass
• [ x ] Clicked around my changes running locally and it works
• [ x ] Checked Desktop, Mobile and Tablet screen sizes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
couchers	✅ Ready (Inspect)	Visit Preview	Oct 20, 2024 10:27pm

[jesseallhands]

Should we change the "communities" and "online" pills to "in-person" and "online"? That's the primary differentiator, right? I don't think we have any in-person events that wouldn't be associated with a community.

[bakeiro]

Should we change the "communities" and "online" pills to "in-person" and "online"? That's the primary differentiator, right? I don't think we have any in-person events that wouldn't be associated with a community.

I think there is a difference, because the community pill shows the events only of the communities that I belong, not just any community

[jesseallhands]

I think there is a difference, because the community pill shows the events only of the communities that I belong, not just any community

In that case the pill should be "my community" and not just "community".

[bakeiro]

not the UI guy here but

I feels this text a bit small... right? (page wasn't zoomed out), if you feel the same, maybe we can increase it :)

[bakeiro]

about the code, was something new added to review? (this is just the merged of the reviewed PRs right?)

[nabramow]

about the code, was something new added to review? (this is just the merged of the reviewed PRs right?)

No, no new functionality! This is just where all those PRs merged into.

[bakeiro]

[suggestion here, no needed to approve the PR or something like that]

I was thinking about the events component in the community page... maybe makes sense to standarize these components? (make them more similar, re-using the same component...)

[nabramow]

[suggestion here, no needed to approve the PR or something like that]

I was thinking about the events component in the community page... maybe makes sense to standarize these components? (make them more similar, re-using the same component...)

I agree! Let's do it in a separate ticket? I'd want more feedback about how the pagination should work for that and any filters, and I think this PR is big enough.