Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(frontend) - fix: read more bug on mobile #5000

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

marco-digennaro
Copy link

@marco-digennaro marco-digennaro commented Oct 17, 2024

closes #4261

  • tuning some margin
  • switched position with vercel button

Backend checklist

  • Formatted my code by running ruff check --select I --fix . && ruff check . && ruff format . in app/backend
  • Added tests for any new code or added a regression test if fixing a bug
  • All tests pass
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • Formatted my code with yarn format
  • There are no warnings from yarn lint --fix
  • There are no console warnings when running the app
  • Added any new components to storybook
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

@marco-digennaro marco-digennaro requested review from aapeliv, bakeiro and a team October 17, 2024 13:15
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Oct 17, 2024 1:16pm

@marco-digennaro marco-digennaro changed the title fix: read more bug on mobile (frontend) - fix: read more bug on mobile Oct 17, 2024
@bakeiro
Copy link
Contributor

bakeiro commented Oct 19, 2024

for contextualize, this is how it looks on my phone
image

Copy link
Contributor

@bakeiro bakeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bakeiro
Copy link
Contributor

bakeiro commented Oct 19, 2024

for me looks good, not sure if @aapeliv, @nabramow has an opinion here...

@nabramow nabramow self-requested a review October 19, 2024 15:54
Copy link
Contributor

@nabramow nabramow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also just tested and looks good to me!

@marco-digennaro
Copy link
Author

can i merge it? what's the policy, 2 approves are enough?

@nabramow
Copy link
Contributor

nabramow commented Oct 20, 2024

can i merge it? what's the policy, 2 approves are enough?

Yeah go for it! 1 is usually enough unless that person says they want a second opinion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

"Read more" text placement issue on landing page (unrelated to cookies banner issue)
3 participants