Add queries to wasmd section #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
uint
requested changes
Sep 2, 2024
There was a problem hiding this comment.
Nice expansion!
For someone coming here without a good understanding of the raw/smart distinction, I think it'd be good to explain it.
I'd mention where appropriate that "raw" means querying the underlying KV storage directly, while "smart" means loading the smart contract and executing one of its "query" endpoints to get the structured data. Or something like that?
If it's there somewhere and I missed it, feel free to call me out on that 😁
| @@ -514,9 +514,9 @@ sleep 6 | |||
| wasmd q tx $(echo "$RESP" | jq -r '.txhash') -o json | jq | |||
| ``` | |||
|
|
|||
| ### Query contract state | |||
| ### Query Contract State All | |||
There was a problem hiding this comment.
Suggested change
| ### Query Contract State All | |
| ### Query Contract State: All |
Just feels a little easier to read when separated like that!
| @@ -557,6 +558,62 @@ The output will be similar to the following: | |||
| } | |||
| ``` | |||
|
|
|||
| ### Query Contract State Raw | |||
There was a problem hiding this comment.
Suggested change
| ### Query Contract State Raw | |
| ### Query Contract State: Raw |
| } | ||
| ``` | ||
|
|
||
| ### Query Contract State Smart |
There was a problem hiding this comment.
Suggested change
| ### Query Contract State Smart | |
| ### Query Contract State: Smart |
chipshort
reviewed
Sep 26, 2024
chipshort
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #140