Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more delegation queries #1788

Merged
merged 20 commits into from
Aug 30, 2023
Merged

Implement more delegation queries #1788

merged 20 commits into from
Aug 30, 2023

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Jul 21, 2023 •
edited by webmaster128
Loading

Closes #1154

webmaster128
webmaster128 reviewed Jul 24, 2023
View reviewed changes
packages/std/src/query/distribution.rs Outdated Show resolved Hide resolved
packages/std/src/query/distribution.rs Show resolved Hide resolved
packages/std/Cargo.toml Show resolved Hide resolved
@chipshort chipshort changed the base branch from release/1.4 to main July 25, 2023 12:28
@chipshort chipshort marked this pull request as ready for review July 26, 2023 14:49
@chipshort chipshort requested a review from hashedone July 31, 2023 11:42
@webmaster128 webmaster128 mentioned this pull request Aug 24, 2023
Merged
@chipshort chipshort force-pushed the 1154-delegation-queries branch 2 times, most recently from e522f85 to 1435937 Compare August 28, 2023 12:32
webmaster128
webmaster128 reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be good here. Let's wait a day or two to see if we get some input by Binary Builders or Alex on the DecCoin API design.

webmaster128
webmaster128 reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, then we just need a rebase and a CHANGELOG entry here

.vscode/settings.json Outdated Show resolved Hide resolved
@chipshort chipshort merged commit 8d8901f into main Aug 30, 2023
3 checks passed
@chipshort chipshort deleted the 1154-delegation-queries branch August 30, 2023 07:53
@webmaster128 webmaster128 mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe left review comments

@webmaster128 webmaster128 webmaster128 approved these changes

@hashedone hashedone Awaiting requested review from hashedone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add query support for Distribution module
3 participants
@chipshort @alpe @webmaster128