Merge pull request #1802 from CosmWasm/improve-padding-test-coverage

Test both long and short width for integer padding
CosmWasm · Jul 27, 2023 · c8491b8 · c8491b8
2 parents 2dfe895 + 10d2fa7
commit c8491b8
Show file tree

Hide file tree

Showing 8 changed files with 48 additions and 4 deletions.
diff --git a/packages/std/src/math/int128.rs b/packages/std/src/math/int128.rs
@@ -625,11 +625,17 @@ mod tests {
 
     #[test]
     fn int128_display_padding_works() {
+        // width > natural representation
         let a = Int128::from(123u64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
-
         let a = Int128::from(-123i64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: -0123");
+
+        // width < natural representation
+        let a = Int128::from(123u64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
+        let a = Int128::from(-123i64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: -123");
     }
 
     #[test]

diff --git a/packages/std/src/math/int256.rs b/packages/std/src/math/int256.rs
@@ -693,11 +693,17 @@ mod tests {
 
     #[test]
     fn int256_display_padding_works() {
+        // width > natural representation
         let a = Int256::from(123u64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
-
         let a = Int256::from(-123i64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: -0123");
+
+        // width < natural representation
+        let a = Int256::from(123u64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
+        let a = Int256::from(-123i64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: -123");
     }
 
     #[test]

diff --git a/packages/std/src/math/int512.rs b/packages/std/src/math/int512.rs
@@ -732,11 +732,17 @@ mod tests {
 
     #[test]
     fn int512_display_padding_works() {
+        // width > natural representation
         let a = Int512::from(123u64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
-
         let a = Int512::from(-123i64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: -0123");
+
+        // width < natural representation
+        let a = Int512::from(123u64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
+        let a = Int512::from(-123i64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: -123");
     }
 
     #[test]

diff --git a/packages/std/src/math/int64.rs b/packages/std/src/math/int64.rs
@@ -595,11 +595,17 @@ mod tests {
 
     #[test]
     fn int64_display_padding_works() {
+        // width > natural representation
         let a = Int64::from(123i64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
-
         let a = Int64::from(-123i64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: -0123");
+
+        // width < natural representation
+        let a = Int64::from(123i64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
+        let a = Int64::from(-123i64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: -123");
     }
 
     #[test]

diff --git a/packages/std/src/math/uint128.rs b/packages/std/src/math/uint128.rs
@@ -690,8 +690,13 @@ mod tests {
 
     #[test]
     fn uint128_display_padding_works() {
+        // width > natural representation
         let a = Uint128::from(123u64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
+
+        // width < natural representation
+        let a = Uint128::from(123u64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
     }
 
     #[test]

diff --git a/packages/std/src/math/uint256.rs b/packages/std/src/math/uint256.rs
@@ -1123,8 +1123,13 @@ mod tests {
 
     #[test]
     fn uint256_display_padding_works() {
+        // width > natural representation
         let a = Uint256::from(123u64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
+
+        // width < natural representation
+        let a = Uint256::from(123u64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
     }
 
     #[test]

diff --git a/packages/std/src/math/uint512.rs b/packages/std/src/math/uint512.rs
@@ -809,8 +809,13 @@ mod tests {
 
     #[test]
     fn uint512_display_padding_works() {
+        // width > natural representation
         let a = Uint512::from(123u64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
+
+        // width < natural representation
+        let a = Uint512::from(123u64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
     }
 
     #[test]

diff --git a/packages/std/src/math/uint64.rs b/packages/std/src/math/uint64.rs
@@ -631,8 +631,13 @@ mod tests {
 
     #[test]
     fn uint64_display_padding_works() {
+        // width > natural representation
         let a = Uint64::from(123u64);
         assert_eq!(format!("Embedded: {a:05}"), "Embedded: 00123");
+
+        // width < natural representation
+        let a = Uint64::from(123u64);
+        assert_eq!(format!("Embedded: {a:02}"), "Embedded: 123");
     }
 
     #[test]