-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action button #3097
Action button #3097
Conversation
When the list of available action types was fixed, they were offered in a known and fixed order in the actions dialog: Now that they're provided via SPI and thus discovered in a random order, is there a way to get a predictable order? Could add a numeric "order" or "priority" to the action info, where the existing ones use values Open Display 10, Write PV 20, ... Present them sorted by that "priority". That allows a local addition to use 100 to appear at the end, but also 15 to sneak into the middle. |
Ah yes, the ordered actions should be supported. |
Fine with me, though personally I would prefer alphabetical order... |
Alphabetical order isn't totally crazy. |
I find a order property a bit ... well, vague. New actions could simple squeeze themselves into any position. What if someone defines order -10? |
Exactly. If you do want to appear before "Open Display" at 10, you can use 9 or 0 or -10. Yes, people will pick the first option simply because it's the first one. But whatever, do what you want, I'll stay out of "actions" from now on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Execute script seems to work as expected now
A clean version of the PR #3017
Resolves the merge conflicts from that branch
Fixes the conversion of embedded scripts
Fixing the the broken script editing
Adds a preference for removing the EDM "close" button in the auto converted screens