Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Disable Until" issue to the alarm log table of the Phoebus #3030

Merged

Conversation

jeonghanlee
Copy link
Contributor

Hi Kunal @shroffk

Please check this, and let me know what you think. We need to talk about how we can handle the "Disable until" time stamp history or log more serious later, since this patch only allows us to run the alarm service especially, alarm log table within Phoebus.

  • Set the "Disable Until" function for a certain period of time for the enabled alarm.
  • After clicking OK, the defined "Disable Until" timestamp is sent to a broker (Kafka service) as a Kafka stream.
  • The alarm server (Kafka consumer) checks the "Disable Until" setting every cycle (1000 ms) and decides whether to enable the disabled alarm or not.
  • The alarm logger (Kafka consumer) converts the received Kafka stream message for the "Disable Until" timestamp into an alarm configuration message and stores it in the running elasticsearch service as a json file. At this point, it saves it as "TimeStamp string" instead of "Boolean true or false".
  • The alarm log table in Phoebus creates a query to retrieve its information manually and automatically.
  • The alarm logger REST service returns the result to the alarm log table in Phoebus.
  • At this point, the alarm log table cannot handle the null exception due to the wrong data format which is a string format instead of Boolean.
  • However, a typical web browser can handle the null exception.
  • This patch only allow us to use forcefully the Boolean data type in order to prevent null exception in the alarm log table of Phoebus.

We may use isEnabled() instead of enabled.enabled. If you want to prefer isEnabled(), please let me know, I will change the code.

@shroffk
Copy link
Member

shroffk commented May 31, 2024

I agree with this short term patch..

@shroffk shroffk merged commit d6a2137 into ControlSystemStudio:master May 31, 2024
1 check passed
@jeonghanlee jeonghanlee deleted the alarm-disable-until-bug branch June 1, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants