-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSSTUDIO-2072 Modified and extended functionality to paste several PV names (with an optional display name) into the Data Browser #3000
base: master
Are you sure you want to change the base?
Conversation
…and-dropped lists of PV names.
…ction DroppedPVNameParser.parseDroppedPVs().
…e Messages.Name (which now has no references).
… with associated display names.
…V names with associated display names.
…e class "Activator".
… PV" window, and rename "layout" -> "gridPane".
…in the "Traces" tab in the Data Browser.
…ead of in Activator.
…me", and do not display the UI-elements for entering "Display Name.
…Vs?" when adding 2 or more PVs.
General comment: this cannot be fully tested unless #2998 is merged first. In
|
Yes, there needs to be a case for |
After a more careful reading of the code, I think it already handles both the case I have now added labels for strings in The PR is ready for review again. |
…drop functionality." This reverts commit 3247b12.
…n DroppedPVNameParser.parseDroppedPVs(). Instead, interpret names that start and end with single quotes as names for the preceding PV name.
…e. This allows for spaces and other separators inside single quotes.
…arser.parseDroppedPVs()." This reverts commit f4110d1.
…oard when pasting PVs into the Data Browser.
The PR has now been updated to implement the proposal described in #3057 (comment). The the original parsing mechanism (that existed before this PR) is now used when parsing PV names, with one modification only: when encountering a single quote character ', the parser will continue to the matching single quote character ', in order to allow for spaces etc in display names; this is how double quotes " and brackets () were handled already. PV names that start and end with single quote characters are interpreted as the display name of the preceding PV name (if it exists). |
I am adding this to the discussion topics for Sept 16th |
This PR implements point 3 described in the discussion #2972, i.e. 3. Modified and extended functionality to paste several PV names (with an optional display name) into the Data Browser. (The PR #2998 implements points 1 and 2 of that discussion.)
In particular, this PR adds a new context-menu item "Add PV(s) from the Clipboard" to the Data Browser that allows one to paste a collection of newline-separated PV names, optionally together with associated Display Names, into the Data Browser:
The collection of pasted PV names can either be added to one axis only that they share, or they can be given individual axes; the following is a screenshot of the dialog that is opened by clicking on "Add PV(s) from the Clipboard":
EDIT (30 July 2024): The PR has now been updated to implement the proposal described in #3057 (comment).
The the original parsing mechanism (that existed before this PR) is now used when parsing PV names, with one modification only: when encountering a single quote character ', the parser will continue to the matching single quote character ', in order to allow for spaces etc in display names; this is how double quotes " and brackets () were handled already.
PV names that start and end with single quote characters are interpreted as the display name of the preceding PV name (if it exists).