-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tab context menu items for easier access to (file) resources #2993
Conversation
app/filebrowser/src/main/java/org/phoebus/applications/filebrowser/FileBrowserController.java
Outdated
Show resolved
Hide resolved
app/filebrowser/src/main/java/org/phoebus/applications/filebrowser/FileBrowserController.java
Outdated
Show resolved
Hide resolved
app/filebrowser/src/main/java/org/phoebus/applications/filebrowser/FileBrowserController.java
Outdated
Show resolved
Hide resolved
core/ui/src/main/java/org/phoebus/ui/docking/DockItemWithInput.java
Outdated
Show resolved
Hide resolved
core/ui/src/main/java/org/phoebus/ui/docking/DockItemWithInput.java
Outdated
Show resolved
Hide resolved
core/ui/src/main/java/org/phoebus/ui/docking/DockItemWithInput.java
Outdated
Show resolved
Hide resolved
services/save-and-restore/src/main/resources/static/CSSTUDIO-1316.bob
Outdated
Show resolved
Hide resolved
core/ui/src/main/java/org/phoebus/ui/docking/DockItemWithInput.java
Outdated
Show resolved
Hide resolved
app/filebrowser/src/main/java/org/phoebus/applications/filebrowser/FileBrowserController.java
Outdated
Show resolved
Hide resolved
core/ui/src/main/java/org/phoebus/ui/docking/DockItemWithInput.java
Outdated
Show resolved
Hide resolved
For what it's worth, good news is that this handles 'unexpected' paths. Again that's good, but a side effect may be that every time "Show in File Browser app" is invoked, it opens a new file browser. |
That is intentional as I could not really determine whether users would be annoyed or grateful for not changing the view of an existing File Browser instance. |
Users often launch the modal Info dialog for the purpose of copying the file path to an OPI. To better support this use case I've added two context menu items, see screen shot:
Had to add some new functionality in
FileBrowserController
to support highlight of resource.Note that this applies only to
DockItemWithInput
instances.